mirror of
https://github.com/saphid/frame-control.git
synced 2026-10-06 09:00:35 +02:00
saphidandClaude Opus 5.5
0d181b676e
From the fix review: - The hero's Install skipped installing whenever a job existed, including one that had failed, so it only opened the details. It now tries again after a failure, and still only opens the details while installing or once installed. - Declaring a var twice is legal, so the strict-mode check couldn't see it. The page's one var (a block-local in the capture code) is now let, and the test rejects var outright (CSS var() in strings is fine). It also checks every inline script, whatever its attributes. - Clear filters still set the removed source filter. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
60 lines
2.7 KiB
Python
60 lines
2.7 KiB
Python
"""The page's inline scripts share one global scope, so a second top-level function or
|
|
variable with a name already used replaces the first everywhere, silently."""
|
|
import json
|
|
import pathlib
|
|
import re
|
|
import shutil
|
|
import subprocess
|
|
import unittest
|
|
|
|
ROOT = pathlib.Path(__file__).resolve().parents[1]
|
|
|
|
# Compiles the scripts as one strict-mode block. There, functions are block scoped like let
|
|
# and const, so V8 itself rejects a name declared twice in the shared scope (however it's
|
|
# indented or declared: function, class, let, const, destructuring), while helpers with the
|
|
# same name inside different functions stay legal. var is the exception (declaring one twice
|
|
# is allowed), so the page doesn't use var at all.
|
|
CHECK = r'''
|
|
const vm = require('vm');
|
|
const scripts = JSON.parse(require('fs').readFileSync(0, 'utf8'));
|
|
const uses = scripts.join('\n').match(/(^|[^\w$.])var\s+[\w${[]/);
|
|
if (uses) { console.log('declares with var: ' + uses[0].trim()); process.exit(0); }
|
|
try { new vm.Script('"use strict"; {\n' + scripts.join('\n;\n') + '\n}'); console.log('ok'); }
|
|
catch (e) { console.log(e.message); }
|
|
'''
|
|
|
|
|
|
def check(scripts):
|
|
r = subprocess.run(['node', '-e', CHECK], input=json.dumps(scripts), capture_output=True, text=True)
|
|
return r.stdout.strip() or r.stderr.strip()
|
|
|
|
|
|
@unittest.skipUnless(shutil.which('node'), 'Node parses the page scripts')
|
|
class PageScripts(unittest.TestCase):
|
|
def test_no_top_level_name_is_declared_twice(self):
|
|
page = (ROOT / 'ui/index.html').read_text(encoding='utf-8')
|
|
# Every inline script, whatever its attributes (not src= ones, which aren't inline).
|
|
scripts = re.findall(r'<script(?![^>]*\bsrc=)[^>]*>(.*?)</script>', page, re.S)
|
|
self.assertGreaterEqual(len(scripts), 2)
|
|
self.assertEqual(check(scripts), 'ok')
|
|
|
|
def test_the_check_finds_what_it_should(self):
|
|
twice = {
|
|
'indented function': ['function loadPanels() {}', ' async function loadPanels() {}'],
|
|
'class': ['class Panel {}', 'class Panel {}'],
|
|
'destructured': ['const { a, b } = {};', 'let [b] = [];'],
|
|
'later declarator': ['let x = 1;', 'const y = 2, x = 3;'],
|
|
'function and const': ['function f() {}', 'const f = 1;'],
|
|
}
|
|
self.assertIn('var', check(['var x = 1;', 'var x = 2;'])) # legal JavaScript, so: no var
|
|
self.assertEqual(check(['const css = "color: var(--blue)";']), 'ok') # CSS var() isn't one
|
|
for what, scripts in twice.items():
|
|
with self.subTest(what):
|
|
self.assertIn('already been declared', check(scripts))
|
|
helpers = ['function a() { function help() {} }', 'function b() { const help = 1; }']
|
|
self.assertEqual(check(helpers), 'ok')
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|