Ryan Houdek
f99900bdc5
Merge pull request #4053 from Sonicadvance1/disable_vixl_compiling
...
CMake: Disable vixl compiling if not enabled
2024-09-09 18:03:46 -07:00
Ryan Houdek
0c3eb41f57
CMake: Disable vixl compiling if not enabled
...
Like how FEXCore disabled vixl linking, make sure we aren't accidentally
compiling and including it when vixl stuff is disabled. Noticed this in
the build logs.
2024-09-09 13:54:35 -07:00
Ryan Houdek
b4c797c199
Merge pull request #4052 from Sonicadvance1/various_warnings
...
Bunch of little things reported by coverity
2024-09-09 12:54:22 -07:00
Ryan Houdek
ebae1bf71d
Merge pull request #4051 from Sonicadvance1/fix_warning
...
Arm64: Fix warning
2024-09-09 08:24:48 -07:00
Ryan Houdek
fa293e5e8f
GDBServer: Fix buffer overrun in x87 register copying
2024-09-08 20:24:17 -07:00
Ryan Houdek
720c89e648
GDBServer: Make it clear we're copying all 512-bytes to clear a warning
2024-09-08 20:23:03 -07:00
Ryan Houdek
abc5f5abd4
GDBServer: Use std::move for move assignment
2024-09-08 20:22:39 -07:00
Ryan Houdek
22ab16b217
Linux/x32/ipc: Fixes version check for msgrcv
...
Also adds an EINVAL return if version 1 is attempted with SHMAT,
mirroring what the kernel returns.
2024-09-08 20:18:11 -07:00
Ryan Houdek
b80f05dd86
Seccomp/BPFEmitter: Reorder check to avoid integer overflow warning
2024-09-08 20:13:14 -07:00
Ryan Houdek
1642a0f4d9
Seccomp/BPFEmitter: Initialize Func,FuncSize just to make coverity happy
2024-09-08 20:10:44 -07:00
Ryan Houdek
96e990dade
SignalDelegator: Use const auto ref to avoid copy
2024-09-08 20:07:45 -07:00
Ryan Houdek
3423a12ab6
SignalDelegator: Remove unused function copying for delegators
2024-09-08 20:06:38 -07:00
Ryan Houdek
c4a0fb6609
Ioctl/drm: Fix missing member copy
2024-09-08 20:02:51 -07:00
Ryan Houdek
8cf23eba9c
FEXLoader/ELFCodeLoader: Use const ref auto to avoid copy
2024-09-08 20:02:51 -07:00
Ryan Houdek
fbe817f1c4
Config: Use std::move on strings to avoid copy
2024-09-08 20:02:51 -07:00
Ryan Houdek
3b61394548
FEXRootFSFetcher: Fixes some extract logic
...
`Extract` was never set to false even if the user said not to overwrite.
Ensure that if the user decided not to overwrite an existing folder,
that it returns false so it correctly doesn't overwrite the folder.
2024-09-08 20:02:51 -07:00
Ryan Houdek
8ed6b36181
FileManagement: Use const ref for AppConfigName
2024-09-08 20:02:51 -07:00
Ryan Houdek
9141322666
Ioctl/drm: Adds missing flags member copying
2024-09-08 20:02:51 -07:00
Ryan Houdek
2d91c5441e
Ioctl/Radeon: Adds missing func member copying
2024-09-08 20:02:51 -07:00
Ryan Houdek
2ff1589c35
FileManagement: Use const ref for Filename
2024-09-08 20:02:51 -07:00
Ryan Houdek
a308b9edbe
Linux/GenerateMap: Fixes FD leak
...
This FD was unused
2024-09-08 19:34:38 -07:00
Ryan Houdek
f6a8e595df
Linux/Syscalls: Add todo for futimesat
2024-09-08 19:34:38 -07:00
Ryan Houdek
eaaf62e4b7
X87: Make it a bit clearer that 80-bit floats can't hit the memory path
...
Makes the static analysis happy.
2024-09-08 18:03:20 -07:00
Ryan Houdek
dc5fc57e19
FEXServer: Check if prctl errors
2024-09-08 18:03:20 -07:00
Ryan Houdek
c3c0bbb060
F80Fallbacks: Fix Uninitialized variable warning that can't occur
2024-09-08 18:03:20 -07:00
Ryan Houdek
98a91d242d
FEXRootFSFetcher: Fixes resource leak on XXHash error
2024-09-08 18:03:20 -07:00
Ryan Houdek
8da6b1e729
FEXCore/Allocator: Fixes uninitialized scalar variable warning that can't occur
2024-09-08 18:03:20 -07:00
Ryan Houdek
d260bce31e
FEXRootFSFetcher: Fixes uninitialized variable
2024-09-08 18:03:20 -07:00
Ryan Houdek
a94aaca0ec
OpcodeDispatcher: Add default FEX_UNREACHABLE
...
This can't happen but if it changes then make sure we capture it.
2024-09-08 18:03:20 -07:00
Ryan Houdek
2ac3ca3ead
pidof: Fix uninitialized variable warning
2024-09-08 18:03:20 -07:00
Ryan Houdek
c559445b62
Linux/IoctlEmulation: Fixes incorrect direction copy for a few ioctls
...
Plus convert remaining handlers over to using CPYF/CPYT handlers so
ensure this doesn't happen again.
2024-09-08 18:03:20 -07:00
Ryan Houdek
8ea4e4f663
Linux: Adds some missing brace initializers on conversion operators
2024-09-08 18:03:20 -07:00
Ryan Houdek
2da700fe82
CodeEmitter: Removes some ternaries that are unnecessary
...
NFC
2024-09-08 18:03:20 -07:00
Ryan Houdek
0a32ba9b29
instcountCI: Fixes for shifts
2024-09-08 18:03:20 -07:00
Ryan Houdek
f51832ca6b
FEXCore: Fixes a bug with VPSRLDQ/VPSLLDQ with >= 16-byte shifts
...
When the shift amount is >= 16-bytes then we need to zero the register.
We had a bug where we were assigning `Result.High` to itself, which
effectively made the top 128-bits of the ymm register not modify itself.
Adds a unit test to ensure that doesn't happen again.
2024-09-08 15:39:22 -07:00
Ryan Houdek
5f9a30af7a
FileManagement: Use const ref for RootFSPath
...
No need to make a copy
2024-09-08 15:20:04 -07:00
Ryan Houdek
453ef0b94c
Linux/ExecveHandler: Move a path rather than copy
...
We can do move assignment instead of copy assignment here.
2024-09-08 15:17:04 -07:00
Ryan Houdek
4779e64cf5
Linux/EmulatedFiles: Check return for seal
...
This shouldn't be possible to occur, but have a log message just in
case.
2024-09-08 15:15:38 -07:00
Ryan Houdek
e6025cc087
Arm64: Fix warning
...
This variable is only used in a log message no, so move it there.
2024-09-08 11:15:46 -07:00
Ryan Houdek
cd4c224dc0
Merge pull request #4050 from alyssarosenzweig/sra/move-size
...
JIT: always use 64-bit moves for SRA
2024-09-08 10:30:17 -07:00
Ryan Houdek
07f117b957
Merge pull request #4047 from bylaws/arm64ec-sysv2
...
ARM64EC: Switch to exception-based native syscall dispatch
2024-09-08 10:30:05 -07:00
Ryan Houdek
36e4f9a070
Merge pull request #4049 from alyssarosenzweig/opt/constprop-merges
...
ConstProp: speed it up
2024-09-08 10:13:23 -07:00
Alyssa Rosenzweig
67c751d3e5
JIT: always use 64-bit moves for SRA
...
I see no reason not to. Simpler code and it's slightly faster on Firestorm.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
2024-09-08 13:02:57 -04:00
Ryan Houdek
1c59bfeb9f
Merge pull request #4027 from alyssarosenzweig/opt/global-flag
...
Global flag optimizations
2024-09-08 09:42:18 -07:00
Alyssa Rosenzweig
2b0041a291
InstCountCI: Update
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
2024-09-08 10:27:20 -04:00
Alyssa Rosenzweig
39cc1e5116
ConstProp: merge folding+inlining
...
2% off nodejs
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
2024-09-08 10:26:58 -04:00
Alyssa Rosenzweig
f46856c090
ConstProp: template constant inlining
...
DRY
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
2024-09-08 10:26:58 -04:00
Alyssa Rosenzweig
b7859052da
ConstProp: don't mask shifts
...
done in the emitter now
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
2024-09-08 10:26:58 -04:00
Alyssa Rosenzweig
3b30d8103f
ConstProp: combine like cases
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
2024-09-08 10:26:58 -04:00
Alyssa Rosenzweig
d19fc36f8f
ConstProp: delay constant pooling
...
more efficient to pool the output of constant folding and such. but we need to
avoid that becoming accidentally quadratic, so rework that too
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
2024-09-08 10:26:58 -04:00