Merge pull request #4674 from neobrain/refactor_todrop

Drop TODO defines

FEXCore/Source/Interface/Core/Core.cpp

@@ -52,7 +52,6 @@ $end_info$
 #include <FEXCore/fextl/sstream.h>
 #include <FEXCore/fextl/vector.h>
 #include <FEXHeaderUtils/Syscalls.h>
-#include <FEXHeaderUtils/TodoDefines.h>
 
 #include <algorithm>
 #include <array>
@@ -405,7 +404,7 @@ void ContextImpl::ExecuteThread(FEXCore::Core::InternalThreadState* Thread) {
   }
 
   // If it is the parent thread that died then just leave
-  FEX_TODO("This doesn't make sense when the parent thread doesn't outlive its children");
+  // TODO: This doesn't make sense when the parent thread doesn't outlive its children
 }
 
 void ContextImpl::InitializeCompiler(FEXCore::Core::InternalThreadState* Thread) {

FEXHeaderUtils/FEXHeaderUtils/TodoDefines.h

@@ -1,22 +0,0 @@
-// SPDX-License-Identifier: MIT
-#pragma once
-
-#ifndef DO_PRAGMA
-#define DO_PRAGMA(x) _Pragma(#x)
-#endif
-
-#if FEX_WARN_TODO
-// FEX_TODO_ISSUE(github ticket number, "comment")
-#define FEX_TODO_ISSUE(github_ticket, comment) DO_PRAGMA(GCC warning "TODO: https://github.com/FEX-Emu/FEX/issues/" #github_ticket comment);
-// FEX_TODO("comment")
-#define FEX_TODO(comment) DO_PRAGMA(GCC warning "TODO: " comment);
-#else
-// FEX_TODO_ISSUE(github ticket number, "comment")
-#define FEX_TODO_ISSUE(github_ticket, comment)
-// FEX_TODO("comment")
-#define FEX_TODO(comment)
-#endif
-
-// For linking to tickets, non-todo
-// FEX_TICKET(github ticket number) or FEX_TICKET(github ticket number, "comment")
-#define FEX_TICKET(github_ticket, ...)

Source/Tools/FEXServer/Main.cpp

@@ -63,7 +63,7 @@ void ClientMsgHandler(int FD, FEXServerClient::Logging::PacketMsg* const Msg, co
 
 namespace {
 void ActionHandler(int sig, siginfo_t* info, void* context) {
-  // FEX_TODO("Fix this");
+  // TODO: Fix this
   if (sig == SIGINT) {
     // Someone trying to kill us. Shutdown.
     ProcessPipe::Shutdown();