steam-frame/FEX-Emu--FEX
1
0 Fork 0
mirror of https://github.com/FEX-Emu/FEX.git synced 2026-10-06 10:00:16 +02:00
Code Issues Packages Projects Releases 66 Wiki Activity

Revert "FEX_TODO: Convert some XXX to FEX_TODO"

Browse Source 
This reverts commit 256df76674.
This commit is contained in:
Tony Wasserka committed 2025-07-15 10:03:56 +02:00
1 parent 4e25bce616
commit a3a55d19b8
2 files changed
+11 -14
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

FEXCore/Source/Interface/Core/Core.cpp
+1 -2
View File
@@ -52,7 +52,6 @@ $end_info$
#include <FEXCore/fextl/sstream.h>
#include <FEXCore/fextl/vector.h>
#include <FEXHeaderUtils/Syscalls.h>
#include <FEXHeaderUtils/TodoDefines.h>
#include <algorithm>
#include <array>
@@ -405,7 +404,7 @@ void ContextImpl::ExecuteThread(FEXCore::Core::InternalThreadState* Thread) {
}
// If it is the parent thread that died then just leave
FEX_TODO("This doesn't make sense when the parent thread doesn't outlive its children");
// TODO: This doesn't make sense when the parent thread doesn't outlive its children
}
void ContextImpl::InitializeCompiler(FEXCore::Core::InternalThreadState* Thread) {
FEXHeaderUtils/FEXHeaderUtils/TodoDefines.h
+10 -12
View File
@@ -6,17 +6,15 @@
#endif
#if FEX_WARN_TODO
// FEX_TODO_ISSUE(github ticket number, "comment")
#define FEX_TODO_ISSUE(github_ticket, comment) DO_PRAGMA(GCC warning "TODO: https://github.com/FEX-Emu/FEX/issues/" #github_ticket comment);
// FEX_TODO("comment")
#define FEX_TODO(comment) DO_PRAGMA(GCC warning "TODO: " comment);
// Use like FEX_TODO_ISSUE(github ticket number, username, comment) or
// FEX_TODO_ISSUE(github ticket number, comment)
#define FEX_TODO_ISSUE(number, ...) DO_PRAGMA(GCC warning "TODO: https://github.com/FEX-Emu/FEX/issues/" #number __VA_ARGS__)
// Use like FEX_TODO(username, comment) or FEX_TODO(comment)
#define FEX_TODO(...) DO_PRAGMA(GCC warning "TODO: " __VA_ARGS__);
#else
// FEX_TODO_ISSUE(github ticket number, "comment")
#define FEX_TODO_ISSUE(github_ticket, comment)
// FEX_TODO("comment")
#define FEX_TODO(comment)
// Use like FEX_TODO_ISSUE(github ticket number, username, comment) or
// FEX_TODO_ISSUE(github ticket number, comment)
#define FEX_TODO_ISSUE(number, ...) do {} while (false)
// Use like FEX_TODO(username, comment) or FEX_TODO(comment)
#define FEX_TODO(...) do {} while (false)
#endif
// For linking to tickets, non-todo
// FEX_TICKET(github ticket number) or FEX_TICKET(github ticket number, "comment")
#define FEX_TICKET(github_ticket, ...)