steam-frame/FEX-Emu--FEX
1
0 Fork 0
mirror of https://github.com/FEX-Emu/FEX.git synced 2026-10-06 10:00:16 +02:00
Code Issues Packages Projects Releases 66 Wiki Activity

ConstProp: Fixes unscaled signed 9-bit range

Browse Source 
The range was slightly incorrect which mostly wouldn't have caused
issues.

The lowest byte would have just generated slightly less optimal code.
The upper byte could have generated broken code, which our CI couldn't
catch since TSO instructions only get enabled when multiple threads are
in-flight.

Easy enough to fix.
This commit is contained in:
Ryan Houdek committed 2023-09-23 01:13:54 -07:00
1 parent 86ad35c418
commit 1f2a3cfa8b
1 file changed
+9 -2
Download Patch File Download Diff File Expand all files Collapse all files
FEXCore/Source/Interface/IR/Passes/ConstProp.cpp
+9 -2
View File
@@ -64,8 +64,15 @@ static bool IsMemoryScale(uint64_t Scale, uint8_t AccessSize) {
return Scale == AccessSize;
}
static bool IsSIMM9Range(uint64_t imm) {
// AArch64 signed immediate unscaled 9-bit range.
// Used for both regular unscaled loadstore instructions
// and LRPCPC2 unscaled loadstore instructions.
return ((int64_t)imm >= -256) && ((int64_t)imm <= 255);
}
static bool IsImmMemory(uint64_t imm, uint8_t AccessSize) {
if ( ((int64_t)imm >= -255) && ((int64_t)imm <= 256) )
if (IsSIMM9Range(imm))
return true;
else if ( (imm & (AccessSize-1)) == 0 && imm/AccessSize <= 4095 )
return true;
@@ -76,7 +83,7 @@ static bool IsImmMemory(uint64_t imm, uint8_t AccessSize) {
static bool IsTSOImm9(uint64_t imm) {
// RCPC2 only has a 9-bit signed offset
if ( ((int64_t)imm >= -256) && ((int64_t)imm <= 255) )
if (IsSIMM9Range(imm))
return true;
else {
return false;