mirror of
https://github.com/saphid/frame-control.git
synced 2026-10-06 04:04:21 +02:00
Skip the stalled-download quit tests on Windows, and say why
Waking a recv blocked in another thread needs the handle closed on Windows, which isn't safe under a TLS read (the previous commit, reverted after review). A stalled download there holds the quit for the 4 s grace period; its partial file is swept on the next start. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
2f5ba5c086
commit
8f379db15e
2 files changed
+12
No files matched your search
@@ -328,6 +328,10 @@ class ServerJobs(unittest.TestCase):
|
||||
self.assertEqual((job["phase"], job["message"]), ("done", "ok"))
|
||||
|
||||
def stall_then_shutdown(self, scheme, reply):
|
||||
if os.name == "nt":
|
||||
# shutdown() from another thread doesn't wake a blocked recv on Windows, and
|
||||
# closing the handle under a TLS read isn't safe; see web-install.md.
|
||||
self.skipTest("Windows: a stalled download is only dropped when the app stops the server")
|
||||
"""Start a download from a server that stalls after sending reply; shutdown must stop it quickly."""
|
||||
stall = socket.socket()
|
||||
stall.bind(("127.0.0.1", 0))
|
||||
|
||||
Reference in new issue
Block a user