Store: real-source fixes found by running search against live repos

- F-Droid: percent-encode repo file names (a '#' in one screenshot name broke
  the whole main repo); a bad image name drops that image, not the app.
- Search: sources still fetching report 'loading' (UI says so and refreshes
  quietly); indexes warm up at server start; page-only SideQuest is not
  searched and appears as a 'Browse SideQuest' link instead of an error.
- Browse (empty query) ranks VR, artwork and recent updates first; the F-Droid
  archive is off by default (old versions only).
- Throttled sources fall back to their last cached copy; per-host message.
- Curated GitHub list gains Open Saber Plus (MIT) with icon and screenshots.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

tests/fixtures/more_sources/artwork-check.json

@@ -1,90 +1,120 @@
 [
-  {
-    "url": "https://avatars.githubusercontent.com/u/2757344?v=4",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://avatars.githubusercontent.com/u/784805?v=4",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://avatars.githubusercontent.com/u/94376830?v=4",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://opengraph.githubassets.com/1/KhronosGroup/OpenXR-SDK-Source",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://opengraph.githubassets.com/1/LWJGL/lwjgl3",
-    "error": "HTTP Error 429: Too Many Requests"
-  },
-  {
-    "url": "https://opengraph.githubassets.com/1/bjornbytes/lovr",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://opengraph.githubassets.com/1/sahibzada-allahyar/YC-Killer",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://raw.githubusercontent.com/KhronosGroup/OpenXR-SDK-Source/3ed64d0f9bb680f24b80a085091e5c8fab38f7b7/src/tests/hello_xr/android_resources/vulkan/mipmap-xxxhdpi/ic_helloxr_launcher.png",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://raw.githubusercontent.com/SgtBilko76/SuperTux-3D/1955493ee6f1000e048c58db40d4904df827210e/data/images/engine/icons/supertux-256x256.png",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://raw.githubusercontent.com/icosa-foundation/open-brush/56acbce831c7e9f257bfee9e21853da99773787b/Assets/Resources/DefaultImages/OpenBrushLogo.png",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://raw.githubusercontent.com/icosa-foundation/open-brush/56acbce831c7e9f257bfee9e21853da99773787b/open-brush.png",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  },
-  {
-    "url": "https://shared.akamai.steamstatic.com/store_item_assets/steam/apps/1634870/ss_0a9c208e26a43cf34879c2ca361d4c8f18af8cba.1920x1080.jpg",
-    "status": 200,
-    "content_type": "image/jpeg",
-    "image": true
-  },
-  {
-    "url": "https://shared.akamai.steamstatic.com/store_item_assets/steam/apps/1634870/ss_19b25b86ef55c0d8769a65135d60eaae8fa40553.1920x1080.jpg",
-    "status": 200,
-    "content_type": "image/jpeg",
-    "image": true
-  },
-  {
-    "url": "https://shared.akamai.steamstatic.com/store_item_assets/steam/apps/1634870/ss_785ea37d63378146dfe0f0ffa3f1d5c155ca978f.1920x1080.jpg",
-    "status": 200,
-    "content_type": "image/jpeg",
-    "image": true
-  },
-  {
-    "url": "https://www.supertux.org/images/0_7_0/github_preview.png",
-    "status": 200,
-    "content_type": "image/png",
-    "image": true
-  }
-]
+ {
+  "url": "https://avatars.githubusercontent.com/u/2757344?v=4",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://avatars.githubusercontent.com/u/784805?v=4",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://avatars.githubusercontent.com/u/94376830?v=4",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://opengraph.githubassets.com/1/KhronosGroup/OpenXR-SDK-Source",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://opengraph.githubassets.com/1/LWJGL/lwjgl3",
+  "error": "HTTP Error 429: Too Many Requests"
+ },
+ {
+  "url": "https://opengraph.githubassets.com/1/bjornbytes/lovr",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://opengraph.githubassets.com/1/sahibzada-allahyar/YC-Killer",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/KhronosGroup/OpenXR-SDK-Source/3ed64d0f9bb680f24b80a085091e5c8fab38f7b7/src/tests/hello_xr/android_resources/vulkan/mipmap-xxxhdpi/ic_helloxr_launcher.png",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/SgtBilko76/SuperTux-3D/1955493ee6f1000e048c58db40d4904df827210e/data/images/engine/icons/supertux-256x256.png",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/icosa-foundation/open-brush/56acbce831c7e9f257bfee9e21853da99773787b/Assets/Resources/DefaultImages/OpenBrushLogo.png",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/icosa-foundation/open-brush/56acbce831c7e9f257bfee9e21853da99773787b/open-brush.png",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://shared.akamai.steamstatic.com/store_item_assets/steam/apps/1634870/ss_0a9c208e26a43cf34879c2ca361d4c8f18af8cba.1920x1080.jpg",
+  "status": 200,
+  "content_type": "image/jpeg",
+  "image": true
+ },
+ {
+  "url": "https://shared.akamai.steamstatic.com/store_item_assets/steam/apps/1634870/ss_19b25b86ef55c0d8769a65135d60eaae8fa40553.1920x1080.jpg",
+  "status": 200,
+  "content_type": "image/jpeg",
+  "image": true
+ },
+ {
+  "url": "https://shared.akamai.steamstatic.com/store_item_assets/steam/apps/1634870/ss_785ea37d63378146dfe0f0ffa3f1d5c155ca978f.1920x1080.jpg",
+  "status": 200,
+  "content_type": "image/jpeg",
+  "image": true
+ },
+ {
+  "url": "https://www.supertux.org/images/0_7_0/github_preview.png",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/arpruss/OpenSaberPlus/8c5295cdaadf02ea7418b0c6cbea20240ba913af/icon.png",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://opengraph.githubassets.com/1/arpruss/OpenSaberPlus",
+  "status": 200,
+  "content_type": "image/png",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/arpruss/OpenSaberPlus/8c5295cdaadf02ea7418b0c6cbea20240ba913af/doc/images/OS0.4.0_1.gif",
+  "status": 200,
+  "content_type": "image/gif",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/arpruss/OpenSaberPlus/8c5295cdaadf02ea7418b0c6cbea20240ba913af/doc/images/OS0.4.0_2.gif",
+  "status": 200,
+  "content_type": "image/gif",
+  "image": true
+ },
+ {
+  "url": "https://raw.githubusercontent.com/arpruss/OpenSaberPlus/8c5295cdaadf02ea7418b0c6cbea20240ba913af/doc/images/OS0.4.0_3.gif",
+  "status": 200,
+  "content_type": "image/gif",
+  "image": true
+ }
+]

tests/test_apk_more_sources.py

@@ -26,7 +26,7 @@ class PublisherSources(unittest.TestCase):
     def test_curated_artwork_has_recorded_image_evidence(self):
         evidence = {r['url']: r for r in json.loads((FIX / 'artwork-check.json').read_text())}
         entries = github.search(github.sources()[0], '')
-        self.assertEqual(len(entries), 3)
+        self.assertEqual(len(entries), 4)
         for entry in entries:
             self.assertTrue(entry['summary'])
             images = entry['images']
@@ -138,8 +138,10 @@ class PublisherSources(unittest.TestCase):
             self.assertEqual(_web.read('https://itch.io/test', ('itch.io',)), b'index')
             self.assertEqual(op.call_count, 1)
         error = urllib.error.HTTPError('https://api.github.com/x', 403, 'limited', {}, None)
-        with patch.object(_web, 'open_url', side_effect=error), self.assertRaisesRegex(SourceError, 'rate limit'):
+        with patch.object(_web, 'open_url', side_effect=error), self.assertRaisesRegex(SourceError, 'FRAME_GITHUB_TOKEN'):
             _web.read('https://api.github.com/x', ('api.github.com',))
+        with patch.object(_web, 'open_url', side_effect=error), patch.object(_web.time, 'time', return_value=1e12):
+            self.assertEqual(_web.read('https://itch.io/test', ('itch.io',)), b'index')  # throttled: stale copy
         with patch.object(_web, 'read', return_value=b'<html>'), self.assertRaises(SourceError):
             github._api('/x')
 

tests/test_apk_search.py

@@ -71,7 +71,7 @@ class SearchTests(SettingsTest):
                 result = search.search(timeout=.03)
                 self.assertLess(time.monotonic() - started, .3)
                 self.assertTrue(result['apps'])
-                self.assertEqual([s['status'] for s in result['sources']], ['ok', 'timed out', 'error'])
+                self.assertEqual([s['status'] for s in result['sources']], ['ok', 'loading', 'error'])
                 search.search('other', timeout=.03)
                 self.assertEqual(calls, [''])
         finally:

tests/test_fdroid_sources.py

@@ -127,6 +127,8 @@ class Repositories(unittest.TestCase):
                 fdroid._url(url)
         with self.assertRaisesRegex(SourceError, 'conflicting'):
             fdroid._url(URL + '?fingerprint=' + PIN, '0' * 64)
+        self.assertEqual(fdroid._child(URL, '/app/en-US/phoneScreenshots/#0 a.png'),
+                         URL + 'app/en-US/phoneScreenshots/%230%20a.png')  # real F-Droid screenshot name
         for name in ['../x.apk', '%2e%2e/x.apk', 'https://evil.org/a.apk', '//evil.org/../x', 'x?token=y', 'x\\y']:
             with self.subTest(name=name), self.assertRaises(SourceError):
                 fdroid._child(URL, name)

tests/test_sidequest.py

@@ -26,8 +26,7 @@ class SideQuestTests(unittest.TestCase):
         self.assertEqual(entry['images']['screenshots'], [])
         with self.assertRaisesRegex(SourceError, 'page-only'):
             sidequest.download(source, '123')
-        with self.assertRaisesRegex(SourceError, 'page-only'):
-            sidequest.search(source, 'open saber')
+        self.assertEqual(sidequest.search(source, 'open saber'), [])
         self.assertEqual(sidequest.search(source, 'open saber', 0), [])
 
     def test_invalid_ids(self):