From 08c306c3a64332d41ac524926f64c1fe3714f3b4 Mon Sep 17 00:00:00 2001 From: saphid <4596216+saphid@users.noreply.github.com> Date: Mon, 28 Sep 2026 22:51:03 +1000 Subject: [PATCH] docs: record CI results and incomplete independent review --- docs/evidence/vr-utilities/review.md | 58 ++++++++++++++++++++++++++++ docs/vr-utilities.md | 7 ++++ 2 files changed, 65 insertions(+) create mode 100644 docs/evidence/vr-utilities/review.md diff --git a/docs/evidence/vr-utilities/review.md b/docs/evidence/vr-utilities/review.md new file mode 100644 index 0000000..ae9b11f --- /dev/null +++ b/docs/evidence/vr-utilities/review.md @@ -0,0 +1,58 @@ +# Independent review attempts — 2026-09-28 + +Target: the implementation and evidence in +[3fb541d](https://github.com/saphid/frame-control/commit/3fb541d) and +[6a63a5a](https://github.com/saphid/frame-control/commit/6a63a5a), supplied as a +frozen diff before those commits were made. No executable code changed after +the final review snapshot. + +Requested model: **SWE-2 Max**, explicitly selected with `--model swe-2-max`. +No completed verdict or model self-identification was returned. This is not a +passed review, and there is no "no actionable findings" claim. + +## First attempt + +Launcher: + +```sh +devin -p --model swe-2-max --permission-mode auto --respect-workspace-trust false --prompt-file /tmp/frame-vr-review-prompt.txt +``` + +The prompt required read-only review, no delegation, no edits and no Frame +access. The reviewer inspected surrounding code, then stopped while checking +the public OpenVR header. The tool runner reported: + +> warning: rejected a tool call that requires confirmation. Running in non-interactive mode. + +The real launcher exit status was **0**, but no verdict was returned. A zero +process status here is not evidence that the review completed. + +## Tool-free retry + +Launcher: + +```sh +devin -p --model swe-2-max --permission-mode auto --respect-workspace-trust false --prompt-file /tmp/frame-vr-review-final-prompt.txt +``` + +The self-contained prompt supplied the complete frozen changes, surrounding +code, standards and locally fetched authoritative OpenVR header excerpts. It +explicitly prohibited tools, edits, delegation and device access. This avoided +the first attempt's permission boundary without escalating permissions. + +No output or verdict arrived within the fifteen-minute review window. The +process was sent SIGTERM at 918 seconds; the shell recorded real exit status +**143**. Findings are unavailable. Review must be completed before considering +this partial draft ready; playspace feasibility is also still paused. + +## Other validation + +- 166 Python unit tests passed locally. +- 8 website tests and UI JavaScript syntax passed locally. +- Desktop and phone-width attached-preview checks passed using live telemetry; + paid optional install buttons were disabled, and unavailable metrics cleared. +- [Fake-Frame CI](https://github.com/saphid/frame-control/actions/runs/36423548487/job/108931878908) + passed, as did Windows/Linux server tests and the main checks job. Docker was + unavailable locally. macOS/iOS jobs were still queued at this handoff. +- Real-device evidence and the paused-control limitation are in + [VR utilities](../../vr-utilities.md). diff --git a/docs/vr-utilities.md b/docs/vr-utilities.md index 1cde0f8..0e73669 100644 --- a/docs/vr-utilities.md +++ b/docs/vr-utilities.md @@ -130,3 +130,10 @@ The optional list shows the latest `works`, `issues` or `broken` report with its date, build and notes, separately from public sources and ownership. With no report the status stays **untested**. No shared database schema change or production deployment is needed; no reports were published by this work. + +## Validation and review + +166 unit tests and 8 website tests passed locally. The new fake-Frame cases +passed in GitHub CI (Docker was unavailable locally). Desktop and phone-width +preview checks passed. The two independent review attempts did not produce a +verdict; [commands, real exit statuses and limitations](evidence/vr-utilities/review.md).