From 93d061b458b99beaf131206c788ba80aadae0eca Mon Sep 17 00:00:00 2001 From: Pierre Kisters <1524059+lhns@users.noreply.github.com> Date: Sun, 27 Sep 2026 23:26:59 +0200 Subject: [PATCH] scripts, icon-fallbacks: small robustness nits check-signatures reads changelist.txt directly instead of looping over a one-element list; icon-fallbacks.sh declares its shell for shellcheck. --- modules/launcher-menu/icon-fallbacks.sh | 1 + scripts/check-signatures.mjs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/launcher-menu/icon-fallbacks.sh b/modules/launcher-menu/icon-fallbacks.sh index b79571e..4d49775 100644 --- a/modules/launcher-menu/icon-fallbacks.sh +++ b/modules/launcher-menu/icon-fallbacks.sh @@ -1,3 +1,4 @@ +# shellcheck shell=bash # Hicolor fallbacks for desktop entry icons that only Breeze has. # # Usage: steam-frame-icon-fallbacks [EXTRA_NAME...] diff --git a/scripts/check-signatures.mjs b/scripts/check-signatures.mjs index 6f9510e..a9383a9 100644 --- a/scripts/check-signatures.mjs +++ b/scripts/check-signatures.mjs @@ -150,8 +150,8 @@ function bundle(name) { ? readdirSync(stylesDir, { recursive: true }).filter((f) => f.endsWith('.css')) .map((f) => ({ file: join(b.styles, f), source: readFileSync(join(stylesDir, f), 'utf8') })) : []; - let version = null; - for (const f of ['changelist.txt']) if (existsSync(join(dir, f))) version = readFileSync(join(dir, f), 'utf8').trim(); + const changelist = join(dir, 'changelist.txt'); + let version = existsSync(changelist) ? readFileSync(changelist, 'utf8').trim() || null : null; for (const f of files ?? []) { if (version) break; try { version = /\bCLSTAMP="(\d+)"/.exec(readFileSync(join(dir, f), 'utf8'))?.[1] ?? null; } catch { /* missing file */ }