Files
FEX-Emu--FEX/Source/Common/FEXServerClient.cpp
T
Ryan Houdek 8876047875 FEXServer: Fixes background startup
The problem here is that the pipe we used for telling FEXInterpreter
that the FEXServer is ready to accept connections was inherited by
erofsfuse or squashfuse. So the closing of the pipe from the FEXServer
side would leave a reference open in squashfuse or erofsfuse.

Fix this by setting FD_CLOEXEC on the pipe, but also pass the pipe FD
through an argument instead of scanning for all pipes.

Then once we execve the squashfuse/erofsfuse application, the FD isn't
inherited.

Fixes #4329
2025-02-09 23:59:32 -08:00

409 lines
13 KiB
C++

// SPDX-License-Identifier: MIT
#include "Common/Config.h"
#include "Common/FEXServerClient.h"
#include <FEXCore/Utils/CompilerDefs.h>
#include <FEXCore/Utils/FileLoading.h>
#include <FEXCore/Utils/LogManager.h>
#include <FEXCore/fextl/fmt.h>
#include <FEXCore/fextl/string.h>
#include <FEXCore/fextl/vector.h>
#include <FEXHeaderUtils/Filesystem.h>
#include <fcntl.h>
#include <linux/limits.h>
#include <unistd.h>
#include <sys/poll.h>
#include <sys/prctl.h>
#include <sys/signal.h>
#include <sys/socket.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <sys/un.h>
#include <sys/uio.h>
#include <thread>
namespace FEXServerClient {
int RequestPIDFDPacket(int ServerSocket, PacketType Type) {
FEXServerRequestPacket Req {
.Header {
.Type = Type,
},
};
int Result = write(ServerSocket, &Req, sizeof(Req.BasicRequest));
if (Result != -1) {
// Wait for success response with SCM_RIGHTS
FEXServerResultPacket Res {};
struct iovec iov {
.iov_base = &Res, .iov_len = sizeof(Res),
};
struct msghdr msg {
.msg_name = nullptr, .msg_namelen = 0, .msg_iov = &iov, .msg_iovlen = 1,
};
// Setup the ancillary buffer. This is where we will be getting pipe FDs
// We only need 4 bytes for the FD
constexpr size_t CMSG_SIZE = CMSG_SPACE(sizeof(int));
union AncillaryBuffer {
struct cmsghdr Header;
uint8_t Buffer[CMSG_SIZE];
};
AncillaryBuffer AncBuf {};
// Now link to our ancilllary buffer
msg.msg_control = AncBuf.Buffer;
msg.msg_controllen = CMSG_SIZE;
ssize_t DataResult = recvmsg(ServerSocket, &msg, 0);
if (DataResult > 0) {
// Now that we have the data, we can extract the FD from the ancillary buffer
struct cmsghdr* cmsg = CMSG_FIRSTHDR(&msg);
// Do some error checking
if (cmsg == nullptr || cmsg->cmsg_len != CMSG_LEN(sizeof(int)) || cmsg->cmsg_level != SOL_SOCKET || cmsg->cmsg_type != SCM_RIGHTS) {
// Couldn't get a socket
} else {
// Check for Success.
// If type error was returned then the FEXServer doesn't have a log to pipe in to
if (Res.Header.Type == PacketType::TYPE_SUCCESS) {
// Now that we know the cmsg is sane, read the FD
int NewFD {};
memcpy(&NewFD, CMSG_DATA(cmsg), sizeof(NewFD));
return NewFD;
}
}
}
}
return -1;
}
static int ServerFD {-1};
fextl::string GetServerLockFolder() {
return FEXCore::Config::GetDataDirectory() + "Server/";
}
fextl::string GetServerLockFile() {
return GetServerLockFolder() + "Server.lock";
}
fextl::string GetServerRootFSLockFile() {
return GetServerLockFolder() + "RootFS.lock";
}
fextl::string GetTempFolder() {
const std::array<const char*, 5> Vars = {
"XDG_RUNTIME_DIR", "TMPDIR", "TMP", "TEMP", "TEMPDIR",
};
for (auto& Var : Vars) {
auto Path = getenv(Var);
if (Path) {
// If one of the env variable-driven paths works then use that.
return Path;
}
}
// Fallback to `/tmp/` if no env vars are set.
// Might not be ideal but we don't have much of a choice.
return fextl::string {"/tmp"};
}
fextl::string GetServerMountFolder() {
// We need a FEXServer mount directory that has some tricky requirements.
// - We don't want to use `/tmp/` if possible.
// - systemd services use `PrivateTmp` feature to gives services their own tmp.
// - We will use this as a fallback path /only/.
// - Can't be `[$XDG_DATA_HOME,$HOME]/.fex-emu/`
// - Might be mounted with a filesystem (sshfs) which can't handle mount points inside it.
//
// Directories it can be in:
// - $XDG_RUNTIME_DIR if set
// - Is typically `/run/user/<UID>/`
// - systemd `PrivateTmp` feature doesn't touch this.
// - If this path doesn't exist then fallback to `/tmp/` as a last resort.
// - pressure-vessel explicitly creates an internal XDG_RUNTIME_DIR inside its chroot.
// - This is okay since pressure-vessel rbinds the FEX rootfs from the host to `/run/pressure-vessel/interpreter-root`.
auto Folder = GetTempFolder();
if (FEXCore::Config::FindContainer() == "pressure-vessel") {
// In pressure-vessel the mount point changes location.
// This is due to pressure-vesssel being a chroot environment.
// It by default maps the host-filesystem to `/run/host/` so we need to redirect.
// After pressure-vessel is fully set up it will set the `FEX_ROOTFS` environment variable,
// which the FEXInterpreter will pick up on.
Folder = "/run/host/" + Folder;
}
return Folder;
}
fextl::string GetServerSocketName() {
FEX_CONFIG_OPT(ServerSocketPath, SERVERSOCKETPATH);
if (ServerSocketPath().empty()) {
return fextl::fmt::format("{}.FEXServer.Socket", ::geteuid());
}
return ServerSocketPath;
}
fextl::string GetServerSocketPath() {
FEX_CONFIG_OPT(ServerSocketPath, SERVERSOCKETPATH);
auto name = ServerSocketPath();
if (name.starts_with("/")) {
return name;
}
auto Folder = GetTempFolder();
if (name.empty()) {
return fextl::fmt::format("{}/{}.FEXServer.Socket", Folder, ::geteuid());
} else {
return fextl::fmt::format("{}/{}", Folder, name);
}
}
int GetServerFD() {
return ServerFD;
}
int ConnectToServer(ConnectionOption ConnectionOption) {
auto ServerSocketName = GetServerSocketName();
// Create the initial unix socket
int SocketFD = socket(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
if (SocketFD == -1) {
LogMan::Msg::EFmt("Couldn't open AF_UNIX socket {}", errno);
return -1;
}
// AF_UNIX has a special feature for named socket paths.
// If the name of the socket begins with `\0` then it is an "abstract" socket address.
// The entirety of the name is used as a path to a socket that doesn't have any filesystem backing.
struct sockaddr_un addr {};
addr.sun_family = AF_UNIX;
size_t SizeOfSocketString = std::min(ServerSocketName.size() + 1, sizeof(addr.sun_path) - 1);
addr.sun_path[0] = 0; // Abstract AF_UNIX sockets start with \0
strncpy(addr.sun_path + 1, ServerSocketName.data(), SizeOfSocketString);
// Include final null character.
size_t SizeOfAddr = sizeof(addr.sun_family) + SizeOfSocketString;
if (connect(SocketFD, reinterpret_cast<struct sockaddr*>(&addr), SizeOfAddr) == -1) {
if (ConnectionOption == ConnectionOption::Default || errno != ECONNREFUSED) {
LogMan::Msg::EFmt("Couldn't connect to FEXServer socket {} {}", ServerSocketName, errno);
}
} else {
return SocketFD;
}
// Try again with a path-based socket, since abstract sockets will fail if we have been
// placed in a new netns as part of a sandbox.
auto ServerSocketPath = GetServerSocketPath();
SizeOfSocketString = std::min(ServerSocketPath.size(), sizeof(addr.sun_path) - 1);
strncpy(addr.sun_path, ServerSocketPath.data(), SizeOfSocketString);
SizeOfAddr = sizeof(addr.sun_family) + SizeOfSocketString;
if (connect(SocketFD, reinterpret_cast<struct sockaddr*>(&addr), SizeOfAddr) == -1) {
if (ConnectionOption == ConnectionOption::Default || (errno != ECONNREFUSED && errno != ENOENT)) {
LogMan::Msg::EFmt("Couldn't connect to FEXServer socket {} {}", ServerSocketPath, errno);
}
} else {
return SocketFD;
}
close(SocketFD);
return -1;
}
bool SetupClient(char* InterpreterPath) {
ServerFD = FEXServerClient::ConnectToAndStartServer(InterpreterPath);
if (ServerFD == -1) {
return false;
}
// If we were started in a container then we want to use the rootfs that they provided.
// In the pressure-vessel case this is a combination of our rootfs and the steam soldier runtime.
if (FEXCore::Config::FindContainer() != "pressure-vessel") {
fextl::string RootFSPath = FEXServerClient::RequestRootFSPath(ServerFD);
//// If everything has passed then we can now update the rootfs path
FEXCore::Config::EraseSet(FEXCore::Config::CONFIG_ROOTFS, RootFSPath);
}
return true;
}
int ConnectToAndStartServer(char* InterpreterPath) {
int ServerFD = ConnectToServer(ConnectionOption::NoPrintConnectionError);
if (ServerFD == -1) {
// Couldn't connect to the server. Start one
// Open some pipes for letting us know when the server is ready
int fds[2] {};
if (pipe2(fds, 0) != 0) {
LogMan::Msg::EFmt("Couldn't open pipe");
return -1;
}
fextl::string FEXServerPath = FHU::Filesystem::ParentPath(InterpreterPath) + "/FEXServer";
// Check if a local FEXServer next to FEXInterpreter exists
// If it does then it takes priority over the installed one
if (!FHU::Filesystem::Exists(FEXServerPath)) {
FEXServerPath = "FEXServer";
}
// Set-up our SIGCHLD handler to ignore the signal.
// This is early in the initialization stage so no handlers have been installed.
//
// We want to ignore the signal so that if FEXServer starts in daemon mode, it
// doesn't leave a zombie process around waiting for something to get the result.
struct sigaction action {};
action.sa_handler = SIG_IGN, sigaction(SIGCHLD, &action, &action);
pid_t pid = fork();
if (pid == 0) {
// Child
close(fds[0]); // Close read end of pipe
const char* argv[4];
auto pipe_string = fextl::fmt::format("{}", fds[1]);
argv[0] = FEXServerPath.c_str();
argv[1] = "--wait_pipe";
argv[2] = pipe_string.c_str();
argv[3] = nullptr;
if (execvp(argv[0], (char* const*)argv) == -1) {
// Let the parent know that we couldn't execute for some reason
uint64_t error {1};
write(fds[1], &error, sizeof(error));
// Give a hopefully helpful error message for users
LogMan::Msg::EFmt("Couldn't execute: {}", argv[0]);
LogMan::Msg::EFmt("This means the squashFS rootfs won't be mounted.");
LogMan::Msg::EFmt("Expect errors!");
// Destroy this fork
exit(1);
}
FEX_UNREACHABLE;
} else {
// Parent
// Wait for the child to exit so we can check if it is mounted or not
close(fds[1]); // Close write end of the pipe
// Wait for a message from FEXServer
pollfd PollFD;
PollFD.fd = fds[0];
PollFD.events = POLLIN | POLLOUT | POLLRDHUP | POLLERR | POLLHUP | POLLNVAL;
// Wait for a result on the pipe that isn't EINTR
while (poll(&PollFD, 1, -1) == -1 && errno == EINTR)
;
for (size_t i = 0; i < 5; ++i) {
ServerFD = ConnectToServer(ConnectionOption::Default);
if (ServerFD != -1) {
break;
}
std::this_thread::sleep_for(std::chrono::seconds(1));
}
if (ServerFD == -1) {
// Still couldn't connect to the socket.
LogMan::Msg::EFmt("Couldn't connect to FEXServer socket {} after launching the process", GetServerSocketName());
}
}
// Restore the original SIGCHLD handler if it existed.
sigaction(SIGCHLD, &action, nullptr);
}
return ServerFD;
}
/**
* @name Packet request functions
* @{ */
void RequestServerKill(int ServerSocket) {
FEXServerRequestPacket Req {
.Header {
.Type = PacketType::TYPE_KILL,
},
};
write(ServerSocket, &Req, sizeof(Req.BasicRequest));
}
int RequestLogFD(int ServerSocket) {
return RequestPIDFDPacket(ServerSocket, PacketType::TYPE_GET_LOG_FD);
}
fextl::string RequestRootFSPath(int ServerSocket) {
FEXServerRequestPacket Req {
.Header {
.Type = PacketType::TYPE_GET_ROOTFS_PATH,
},
};
int Result = write(ServerSocket, &Req, sizeof(Req.BasicRequest));
if (Result != -1) {
// Wait for success response with data
fextl::vector<char> Data(PATH_MAX + sizeof(FEXServerResultPacket));
ssize_t DataResult = recv(ServerSocket, Data.data(), Data.size(), 0);
if (DataResult >= sizeof(FEXServerResultPacket)) {
FEXServerResultPacket* ResultPacket = reinterpret_cast<FEXServerResultPacket*>(Data.data());
if (ResultPacket->Header.Type == PacketType::TYPE_GET_ROOTFS_PATH && ResultPacket->MountPath.Length > 0) {
return fextl::string(ResultPacket->MountPath.Mount);
}
}
}
return {};
}
int RequestPIDFD(int ServerSocket) {
return RequestPIDFDPacket(ServerSocket, PacketType::TYPE_GET_PID_FD);
}
/** @} */
/**
* @name FEX logging through FEXServer
* @{ */
void MsgHandler(int FD, LogMan::DebugLevels Level, const char* Message) {
size_t MsgLen = strlen(Message) + 1;
Logging::PacketMsg Msg;
Msg.Header = Logging::FillHeader(Logging::PacketTypes::TYPE_MSG);
Msg.MessageLength = MsgLen;
Msg.Level = Level;
const iovec vec[2] = {
{
.iov_base = &Msg,
.iov_len = sizeof(Msg),
},
{
.iov_base = const_cast<char*>(Message),
.iov_len = Msg.MessageLength,
},
};
writev(FD, vec, 2);
}
void AssertHandler(int FD, const char* Message) {
MsgHandler(FD, LogMan::DebugLevels::ASSERT, Message);
}
/** @} */
} // namespace FEXServerClient