mirror of
https://github.com/FEX-Emu/FEX.git
synced 2026-10-06 20:00:16 +02:00
Ryan Houdek
b89ebd931e
Fixes crash that occurs in applications that use both GL and Vulkan, Like UE5 Vulkan native games. Fixes Ender Magnolia. The issue here is that UE5 loads libGL first, which initializes our libGL thunks, setting its X11Manager's functions. It then loads libvulkan, which calls our oninit constructor, which because of the symbol conflict, calls in to the libGL thunk's host functions to reinitialize its function pointers, never initializing the Vulkan X11Manager's functions. It would then crash as soon as an X11 function was used. Give them unique symbol names so we don't accidentally look up the incorrect symbol.
94 lines
2.9 KiB
C++
94 lines
2.9 KiB
C++
/*
|
|
$info$
|
|
tags: thunklibs|GL
|
|
desc: Handles glXGetProcAddress
|
|
$end_info$
|
|
*/
|
|
|
|
#define GL_GLEXT_PROTOTYPES 1
|
|
#define GLX_GLXEXT_PROTOTYPES 1
|
|
|
|
#include <GL/glx.h>
|
|
#include <GL/glxext.h>
|
|
#include <GL/gl.h>
|
|
#include <GL/glext.h>
|
|
|
|
#undef GL_ARB_viewport_array
|
|
#include "glcorearb.h"
|
|
|
|
#include <dlfcn.h>
|
|
#include <cstdio>
|
|
#include <cstdlib>
|
|
#include <cstring>
|
|
#include <functional>
|
|
#include <string_view>
|
|
#include <unordered_map>
|
|
|
|
#include "common/Guest.h"
|
|
|
|
#include "thunkgen_guest_libGL.inl"
|
|
|
|
typedef void voidFunc();
|
|
|
|
// Maps OpenGL API function names to the address of a guest function which is
|
|
// linked to the corresponding host function pointer
|
|
const std::unordered_map<std::string_view, uintptr_t /* guest function address */> HostPtrInvokers = std::invoke([]() {
|
|
#define PAIR(name, unused) Ret[#name] = reinterpret_cast<uintptr_t>(GetCallerForHostFunction(name));
|
|
std::unordered_map<std::string_view, uintptr_t> Ret;
|
|
FOREACH_internal_SYMBOL(PAIR);
|
|
return Ret;
|
|
#undef PAIR
|
|
});
|
|
|
|
extern "C" {
|
|
voidFunc* glXGetProcAddress(const GLubyte* procname) {
|
|
auto Ret = fexfn_pack_glXGetProcAddress(procname);
|
|
if (!Ret) {
|
|
return nullptr;
|
|
}
|
|
|
|
auto TargetFuncIt = HostPtrInvokers.find(reinterpret_cast<const char*>(procname));
|
|
if (TargetFuncIt == HostPtrInvokers.end()) {
|
|
std::string_view procname_s {reinterpret_cast<const char*>(procname)};
|
|
// If glXGetProcAddress is querying itself, then we can just return itself.
|
|
// Some games do this for unknown reasons.
|
|
if (procname_s == "glXGetProcAddress" || procname_s == "glXGetProcAddressARB") {
|
|
return reinterpret_cast<voidFunc*>(glXGetProcAddress);
|
|
}
|
|
|
|
// Extension found in host but not in our interface definition => Not fatal but warn about it
|
|
// Some games query leaked GLES symbols but don't use them
|
|
// glFrustrumf : ES 1.x function
|
|
// - Papers, Please
|
|
// - Dicey Dungeons
|
|
fprintf(stderr, "glXGetProcAddress: not found %s\n", procname);
|
|
return nullptr;
|
|
}
|
|
|
|
LinkAddressToFunction((uintptr_t)Ret, TargetFuncIt->second);
|
|
return Ret;
|
|
}
|
|
|
|
voidFunc* glXGetProcAddressARB(const GLubyte* procname) {
|
|
return glXGetProcAddress(procname);
|
|
}
|
|
}
|
|
|
|
// Wrapper around malloc() without noexcept specifiers
|
|
static void* malloc_wrapper(size_t size) {
|
|
return malloc(size);
|
|
}
|
|
|
|
static void OnInit() {
|
|
fexfn_pack_GL_SetGuestMalloc((uintptr_t)malloc_wrapper, (uintptr_t)CallbackUnpack<decltype(malloc_wrapper)>::Unpack);
|
|
fexfn_pack_GL_SetGuestXSync((uintptr_t)XSync, (uintptr_t)CallbackUnpack<decltype(XSync)>::Unpack);
|
|
fexfn_pack_GL_SetGuestXGetVisualInfo((uintptr_t)XGetVisualInfo, (uintptr_t)CallbackUnpack<decltype(XGetVisualInfo)>::Unpack);
|
|
fexfn_pack_GL_SetGuestXDisplayString((uintptr_t)XDisplayString, (uintptr_t)CallbackUnpack<decltype(XDisplayString)>::Unpack);
|
|
}
|
|
|
|
// libGL.so must pull in libX11.so as a dependency. Referencing some libX11
|
|
// symbol here prevents the linker from optimizing away the unused dependency
|
|
auto implicit_libx11_dependency = XSetErrorHandler;
|
|
|
|
LOAD_LIB_INIT(libGL, OnInit)
|