mirror of
https://github.com/FEX-Emu/FEX.git
synced 2026-10-10 08:00:20 +02:00
For correct carry/overflow behaviour, we need to use a compare of the right size. The existing logic to look at the source sizes doesn't work for this, since a 32-bit NEG instruction will compare a 32-bit source with a 64-bit _Constant(0) .. which needs a 32-bit compare but the existing logic would use a 64-bit compare. This is not yet a bug fix, since the overflow code is currently in software for 32-bit negates so it's irrelevant. But it should prevent regressions from using native compares later in this series. Presumably this was intended all along but left as-is to avoid disturbing instcountci once noticed. Time to disturb CI! Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>