From eb76dbdf4d3f20d6dbc5689f252e207681ea9420 Mon Sep 17 00:00:00 2001 From: Paulo Matos Date: Wed, 2 Oct 2024 18:27:51 +0200 Subject: [PATCH] x87 small cleanups; NFC --- .../Interface/Core/OpcodeDispatcher/X87.cpp | 2 -- .../Core/OpcodeDispatcher/X87F64.cpp | 20 ------------------- .../IR/Passes/x87StackOptimizationPass.cpp | 1 - 3 files changed, 23 deletions(-) diff --git a/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87.cpp b/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87.cpp index 0fae5c44f..5b7344f92 100644 --- a/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87.cpp +++ b/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87.cpp @@ -150,8 +150,6 @@ void OpDispatchBuilder::FSTToStack(OpcodeArgs) { // Store integer to memory (possibly with truncation) void OpDispatchBuilder::FIST(OpcodeArgs, bool Truncate) { auto Size = GetSrcSize(Op); - // FIXME(pmatos): is there any advantage of using STORESTACKMEMORY here? - // Do we need STORESTACKMEMORY at all? Ref Data = _ReadStackValue(0); Data = _F80CVTInt(Size, Data, Truncate); diff --git a/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87F64.cpp b/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87F64.cpp index 684a4cf4a..e5bca53d9 100644 --- a/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87F64.cpp +++ b/FEXCore/Source/Interface/Core/OpcodeDispatcher/X87F64.cpp @@ -22,26 +22,6 @@ class OrderedNode; #define OpcodeArgs [[maybe_unused]] FEXCore::X86Tables::DecodedOp Op -// Functions in X87.cpp (no change required) -// GetX87Top -// SetX87ValidTag -// GetX87ValidTag -// GetX87Tag (will need changing once special tag handling is implemented) -// SetX87FTW -// GetX87FTW (will need changing once special tag handling is implemented) -// SetX87Top -// X87ModifySTP -// EMMS -// FFREE -// FNSTENV -// FSTCW -// LDSW -// FNSTSW -// FXCH -// FCMOV -// FST(register to register) -// FCHS - void OpDispatchBuilder::FNINITF64(OpcodeArgs) { // Init host rounding mode to zero auto Zero = _Constant(0); diff --git a/FEXCore/Source/Interface/IR/Passes/x87StackOptimizationPass.cpp b/FEXCore/Source/Interface/IR/Passes/x87StackOptimizationPass.cpp index 3e5141dbb..ccab50eda 100644 --- a/FEXCore/Source/Interface/IR/Passes/x87StackOptimizationPass.cpp +++ b/FEXCore/Source/Interface/IR/Passes/x87StackOptimizationPass.cpp @@ -644,7 +644,6 @@ void X87StackOptimization::Run(IREmitter* Emit) { case OP_F80SINSTACK: { HandleUnop(OP_F64SIN, false, OP_F80SIN); - break; }