From e42dd5ddfb4b65581982355a91828e449a23f93c Mon Sep 17 00:00:00 2001 From: crueter Date: Sat, 27 Dec 2025 21:02:28 -0500 Subject: [PATCH] [cmake] do not use uppercase command names Command names shouldn't be uppercase. A lot of LSPs scold you if you do this, and apparently it's the official recommendation from the CMake team to absolutely never, ever do this. Signed-off-by: crueter --- CMakeLists.txt | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 08df60269..23ca55086 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,8 +1,8 @@ cmake_minimum_required(VERSION 3.14) project(FEX C CXX ASM) -INCLUDE (CheckIncludeFiles) -CHECK_INCLUDE_FILES ("gdb/jit-reader.h" HAVE_GDB_JIT_READER_H) +include(CheckIncludeFiles) +check_include_files("gdb/jit-reader.h" HAVE_GDB_JIT_READER_H) option(BUILD_FEX_LINUX_TESTS "Build FEXLinuxTests, requires x86 compiler" FALSE) option(BUILD_THUNKS "Build thunks" FALSE) @@ -586,20 +586,18 @@ if (BUILD_THUNKS) DEPENDS thunkgen) install( - CODE "MESSAGE(\"-- Installing: guest-libs\")" + CODE "message(\"-- Installing: guest-libs\")" CODE " - EXECUTE_PROCESS(COMMAND ${CMAKE_COMMAND} --build . --target install - WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/Guest - )" + execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install + WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/Guest)" DEPENDS guest-libs COMPONENT Runtime) install( - CODE "MESSAGE(\"-- Installing: guest-libs-32\")" + CODE "message(\"-- Installing: guest-libs-32\")" CODE " - EXECUTE_PROCESS(COMMAND ${CMAKE_COMMAND} --build . --target install - WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/Guest_32 - )" + execute_process(COMMAND ${CMAKE_COMMAND} --build . --target install + WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/Guest_32)" DEPENDS guest-libs-32 COMPONENT Runtime)