From dfd1aedae5eec691d18802d07df89c9c47faf277 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 14 May 2025 16:23:22 -0400 Subject: [PATCH] JIT: use .ID() even less oops, missed a "/g" with th sed. Signed-off-by: Alyssa Rosenzweig --- FEXCore/Source/Interface/Core/JIT/ALUOps.cpp | 30 +++++++++---------- FEXCore/Source/Interface/Core/JIT/MoveOps.cpp | 2 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/FEXCore/Source/Interface/Core/JIT/ALUOps.cpp b/FEXCore/Source/Interface/Core/JIT/ALUOps.cpp index 874d2fcde..3538f8290 100644 --- a/FEXCore/Source/Interface/Core/JIT/ALUOps.cpp +++ b/FEXCore/Source/Interface/Core/JIT/ALUOps.cpp @@ -88,7 +88,7 @@ DEF_OP(CycleCounter) { DEF_OP(AddShift) { auto Op = IROp->C(); - add(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2.ID()), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); + add(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); } DEF_OP(AddNZCV) { @@ -114,7 +114,7 @@ DEF_OP(AddNZCV) { DEF_OP(AdcNZCV) { auto Op = IROp->C(); - adcs(ConvertSize48(IROp), ARMEmitter::Reg::zr, GetReg(Op->Src1), GetReg(Op->Src2.ID())); + adcs(ConvertSize48(IROp), ARMEmitter::Reg::zr, GetReg(Op->Src1), GetReg(Op->Src2)); } DEF_OP(AdcWithFlags) { @@ -147,13 +147,13 @@ DEF_OP(Adc) { DEF_OP(SbbWithFlags) { auto Op = IROp->C(); - sbcs(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2.ID())); + sbcs(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2)); } DEF_OP(SbbNZCV) { auto Op = IROp->C(); - sbcs(ConvertSize48(IROp), ARMEmitter::Reg::zr, GetReg(Op->Src1), GetReg(Op->Src2.ID())); + sbcs(ConvertSize48(IROp), ARMEmitter::Reg::zr, GetReg(Op->Src1), GetReg(Op->Src2)); } DEF_OP(Sbb) { @@ -225,7 +225,7 @@ DEF_OP(TestZ) { DEF_OP(SubShift) { auto Op = IROp->C(); - sub(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2.ID()), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); + sub(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); } DEF_OP(SubNZCV) { @@ -264,8 +264,8 @@ DEF_OP(CmpPairZ) { mrs(TMP1, ARMEmitter::SystemRegister::NZCV); // Compare, setting Z and clobbering NzCV - cmp(EmitSize, GetReg(Op->Src1Lo), GetReg(Op->Src2Lo.ID())); - ccmp(EmitSize, GetReg(Op->Src1Hi), GetReg(Op->Src2Hi.ID()), ARMEmitter::StatusFlags::None, ARMEmitter::Condition::CC_EQ); + cmp(EmitSize, GetReg(Op->Src1Lo), GetReg(Op->Src2Lo)); + ccmp(EmitSize, GetReg(Op->Src1Hi), GetReg(Op->Src2Hi), ARMEmitter::StatusFlags::None, ARMEmitter::Condition::CC_EQ); // Restore NzCV if (CTX->HostFeatures.SupportsFlagM) { @@ -384,23 +384,23 @@ DEF_OP(Neg) { DEF_OP(Mul) { auto Op = IROp->C(); - mul(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2.ID())); + mul(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2)); } DEF_OP(UMul) { auto Op = IROp->C(); - mul(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2.ID())); + mul(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2)); } DEF_OP(UMull) { auto Op = IROp->C(); - umull(GetReg(Node).X(), GetReg(Op->Src1).W(), GetReg(Op->Src2.ID()).W()); + umull(GetReg(Node).X(), GetReg(Op->Src1).W(), GetReg(Op->Src2).W()); } DEF_OP(SMull) { auto Op = IROp->C(); - smull(GetReg(Node).X(), GetReg(Op->Src1).W(), GetReg(Op->Src2.ID()).W()); + smull(GetReg(Node).X(), GetReg(Op->Src1).W(), GetReg(Op->Src2).W()); } DEF_OP(Div) { @@ -636,13 +636,13 @@ DEF_OP(AndWithFlags) { DEF_OP(XorShift) { auto Op = IROp->C(); - eor(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2.ID()), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); + eor(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); } DEF_OP(XornShift) { auto Op = IROp->C(); - eon(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2.ID()), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); + eon(ConvertSize48(IROp), GetReg(Node), GetReg(Op->Src1), GetReg(Op->Src2), ConvertIRShiftType(Op->Shift), Op->ShiftAmount); } DEF_OP(Ashr) { @@ -1508,7 +1508,7 @@ DEF_OP(Select) { cset(EmitSize, Dst, cc); } } else { - csel(EmitSize, Dst, GetReg(Op->TrueVal), GetReg(Op->FalseVal.ID()), cc); + csel(EmitSize, Dst, GetReg(Op->TrueVal), GetReg(Op->FalseVal), cc); } } @@ -1546,7 +1546,7 @@ DEF_OP(NZCVSelectV) { auto cc = MapCC(Op->Cond); const auto SubRegSize = ConvertSubRegSizePair248(IROp); - fcsel(SubRegSize.Scalar, GetVReg(Node), GetVReg(Op->TrueVal), GetVReg(Op->FalseVal.ID()), cc); + fcsel(SubRegSize.Scalar, GetVReg(Node), GetVReg(Op->TrueVal), GetVReg(Op->FalseVal), cc); } DEF_OP(NZCVSelectIncrement) { diff --git a/FEXCore/Source/Interface/Core/JIT/MoveOps.cpp b/FEXCore/Source/Interface/Core/JIT/MoveOps.cpp index effec40e8..627c96b5d 100644 --- a/FEXCore/Source/Interface/Core/JIT/MoveOps.cpp +++ b/FEXCore/Source/Interface/Core/JIT/MoveOps.cpp @@ -27,7 +27,7 @@ DEF_OP(RMWHandle) { DEF_OP(Swap1) { auto Op = IROp->C(); - auto A = GetReg(Op->A), B = GetReg(Op->B.ID()); + auto A = GetReg(Op->A), B = GetReg(Op->B); LOGMAN_THROW_A_FMT(B == GetReg(Node), "Invariant"); mov(ARMEmitter::Size::i64Bit, TMP1, A);