From cad4cb9b6454cc219954f4f7e4837eb33d70e4d4 Mon Sep 17 00:00:00 2001 From: Ryan Houdek Date: Mon, 14 Sep 2026 16:59:30 -0700 Subject: [PATCH] Frontend: Remove SRC_RCX subflag --- FEXCore/Source/Interface/Core/Frontend.cpp | 7 ------- FEXCore/Source/Interface/Core/X86Tables/X86Tables.h | 3 +-- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/FEXCore/Source/Interface/Core/Frontend.cpp b/FEXCore/Source/Interface/Core/Frontend.cpp index fe983b19f..eb026e546 100644 --- a/FEXCore/Source/Interface/Core/Frontend.cpp +++ b/FEXCore/Source/Interface/Core/Frontend.cpp @@ -625,13 +625,6 @@ Decoder::DecodedBlockStatus Decoder::NormalOp(const FEXCore::X86Tables::X86InstI ++CurrentSrc; } - if (HAS_NON_XMM_SUBFLAG(Info->Flags, FEXCore::X86Tables::InstFlags::FLAGS_SF_SRC_RCX)) { - DecodeInst->Src[CurrentSrc].Type = DecodedOperand::OpType::GPR; - DecodeInst->Src[CurrentSrc].Data.GPR.HighBits = false; - DecodeInst->Src[CurrentSrc].Data.GPR.GPR = FEXCore::X86State::REG_RCX; - ++CurrentSrc; - } - if (VEXOperand == FEXCore::X86Tables::InstFlags::FLAGS_VEX_DST) { CurrentDest->Type = DecodedOperand::OpType::GPR; CurrentDest->Data.GPR.HighBits = false; diff --git a/FEXCore/Source/Interface/Core/X86Tables/X86Tables.h b/FEXCore/Source/Interface/Core/X86Tables/X86Tables.h index f5981529d..915a0bf29 100644 --- a/FEXCore/Source/Interface/Core/X86Tables/X86Tables.h +++ b/FEXCore/Source/Interface/Core/X86Tables/X86Tables.h @@ -356,8 +356,7 @@ namespace InstFlags { // Non-XMM subflags constexpr InstFlagType FLAGS_SF_DST_RAX = (1ULL << 11); - // subflag [13:12] unused - constexpr InstFlagType FLAGS_SF_SRC_RCX = (1ULL << 14); + // subflag [14:12] unused constexpr InstFlagType FLAGS_SF_REX_IN_BYTE = (1ULL << 15); // XMM subflags