From a30593efd67005dda29ccda27bcb0cc398c410e6 Mon Sep 17 00:00:00 2001 From: Ryan Houdek Date: Fri, 12 Sep 2025 17:30:31 -0700 Subject: [PATCH] OpcodeDispatcher: Removes a log about unknown segments This behaves like `UnimplementedOp`, giving a SIGILL if it actually gets hit. --- FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp b/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp index a49eb286f..321c8ab5d 100644 --- a/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp +++ b/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp @@ -1285,10 +1285,7 @@ void OpDispatchBuilder::MOVSegOp(OpcodeArgs, bool ToSeg) { DecodeFailure = true; } break; - default: - LogMan::Msg::EFmt("Unknown segment register: {}", Op->Dest.Data.GPR.GPR); - DecodeFailure = true; - break; + default: UnimplementedOp(Op); return; } } else { Ref Segment {}; @@ -1326,10 +1323,7 @@ void OpDispatchBuilder::MOVSegOp(OpcodeArgs, bool ToSeg) { Segment = _LoadContext(OpSize::i16Bit, GPRClass, offsetof(FEXCore::Core::CPUState, fs_idx)); } break; - default: - LogMan::Msg::EFmt("Unknown segment register: {}", Op->Dest.Data.GPR.GPR); - DecodeFailure = true; - return; + default: UnimplementedOp(Op); return; } if (DestIsMem(Op)) { // If the destination is memory then we always store 16-bits only