diff --git a/FEXCore/Source/Interface/IR/AOTIR.cpp b/FEXCore/Source/Interface/IR/AOTIR.cpp index 8d2cd32fc..cdb9dbd1a 100644 --- a/FEXCore/Source/Interface/IR/AOTIR.cpp +++ b/FEXCore/Source/Interface/IR/AOTIR.cpp @@ -338,7 +338,7 @@ bool AOTIRCaptureCache::PostCompileCode(FEXCore::Core::InternalThreadState* Thre auto LocalRIP = GuestRIP - AOTIRCacheEntry.VAFileStart; auto LocalStartAddr = StartAddr - AOTIRCacheEntry.VAFileStart; - auto FileId = AOTIRCacheEntry.Entry->FileId; + const auto& FileId = AOTIRCacheEntry.Entry->FileId; // The lambda is converted to std::function. This is tricky to refactor so it doesn't allocate memory through glibc. // NOTE: unique_ptr must be passed as a raw pointer since std::function requires lambda captures to be copyable diff --git a/FEXCore/Source/Interface/IR/Passes/IRDumperPass.cpp b/FEXCore/Source/Interface/IR/Passes/IRDumperPass.cpp index 160723ce2..80ce1960e 100644 --- a/FEXCore/Source/Interface/IR/Passes/IRDumperPass.cpp +++ b/FEXCore/Source/Interface/IR/Passes/IRDumperPass.cpp @@ -27,7 +27,7 @@ private: }; IRDumper::IRDumper() { - const auto DumpIRStr = DumpIR(); + const auto& DumpIRStr = DumpIR(); if (DumpIRStr == "stderr" || DumpIRStr == "stdout" || DumpIRStr == "no") { // Intentionally do nothing } else if (DumpIRStr == "server") { diff --git a/FEXCore/Source/Utils/Telemetry.cpp b/FEXCore/Source/Utils/Telemetry.cpp index 62d173005..c091e83f7 100644 --- a/FEXCore/Source/Utils/Telemetry.cpp +++ b/FEXCore/Source/Utils/Telemetry.cpp @@ -45,7 +45,7 @@ void Initialize() { return; } - auto DataDirectory = Config::GetTelemetryDirectory(); + const auto& DataDirectory = Config::GetTelemetryDirectory(); // Ensure the folder structure is created for our configuration if (!FHU::Filesystem::Exists(DataDirectory) && !FHU::Filesystem::CreateDirectories(DataDirectory)) { diff --git a/Source/Tools/CodeSizeValidation/Main.cpp b/Source/Tools/CodeSizeValidation/Main.cpp index 420e5d84c..6261d2f0b 100644 --- a/Source/Tools/CodeSizeValidation/Main.cpp +++ b/Source/Tools/CodeSizeValidation/Main.cpp @@ -291,7 +291,7 @@ static bool TestInstructions(FEXCore::Context::Context* CTX, FEXCore::Core::Inte bool ShouldShowCode = INSTStats->first.HostCodeInstructions != CurrentTest->ExpectedInstructionCount; if (ShouldShowCode) { - for (auto Line : INSTStats->second) { + for (const auto& Line : INSTStats->second) { LogMan::Msg::EFmt("\t{}", Line); } } diff --git a/Source/Tools/FEXLoader/FEXLoader.cpp b/Source/Tools/FEXLoader/FEXLoader.cpp index 3d40f66ac..d7b4b21c8 100644 --- a/Source/Tools/FEXLoader/FEXLoader.cpp +++ b/Source/Tools/FEXLoader/FEXLoader.cpp @@ -360,7 +360,7 @@ int main(int argc, char** argv, char** const envp) { LogMan::Throw::UnInstallHandler(); LogMan::Msg::UnInstallHandler(); } else { - auto LogFile = OutputLog(); + const auto& LogFile = OutputLog(); // If stderr or stdout then we need to dup the FD // In some cases some applications will close stderr and stdout // then redirect the FD to either a log OR some cases just not use diff --git a/Source/Tools/FEXRootFSFetcher/Main.cpp b/Source/Tools/FEXRootFSFetcher/Main.cpp index 50d4a4af2..3aa4ff527 100644 --- a/Source/Tools/FEXRootFSFetcher/Main.cpp +++ b/Source/Tools/FEXRootFSFetcher/Main.cpp @@ -96,7 +96,7 @@ void ParseArguments(int argc, char** argv) { } if (Options.is_set_by_user("force_ui")) { - auto Option = Options["force_ui"]; + const auto& Option = Options["force_ui"]; if (Option == "tty") { UIOption = UIOverrideOption::TTY; } else if (Option == "zenity") { diff --git a/Source/Tools/LinuxEmulation/LinuxSyscalls/FileManagement.cpp b/Source/Tools/LinuxEmulation/LinuxSyscalls/FileManagement.cpp index 240cf4607..9c297d76b 100644 --- a/Source/Tools/LinuxEmulation/LinuxSyscalls/FileManagement.cpp +++ b/Source/Tools/LinuxEmulation/LinuxSyscalls/FileManagement.cpp @@ -263,7 +263,7 @@ FileManager::FileManager(FEXCore::Context::Context* ctx) } // Now that we loaded the thunks object, walk through and ensure dependencies are enabled as well - auto ThunkGuestPath = Is64BitMode() ? ThunkGuestLibs() : ThunkGuestLibs32(); + const auto& ThunkGuestPath = Is64BitMode() ? ThunkGuestLibs() : ThunkGuestLibs32(); for (const auto& DBObject : ThunkDB) { if (!DBObject.second.Enabled) { continue;