steam-frame/FEX-Emu--FEX
1
0 Fork 0
mirror of https://github.com/FEX-Emu/FEX.git synced 2026-10-06 17:00:19 +02:00
Code Issues Packages Projects Releases 66 Wiki Activity

Frontend: avoid cache patching for certain cases with data unlikely to change

Browse Source 
The MOV heuristic shaves off a ton of patch sites (storage and overhead on
Lookup) where the data doesn't seem to change in practice.
This commit is contained in:
Pierre-Loup A. Griffais committed 2026-09-14 21:52:14 -07:00
1 parent 1695d742b1
commit 56a4f11ddb
1 file changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files
FEXCore/Source/Interface/Core/Frontend.cpp
+6 -6
View File
@@ -1415,11 +1415,11 @@ void Decoder::DetectDataMasks(uint64_t OpAddress, DecodedBlocks& Block) {
}
// heuristic: if it's a small value, assume it's more likely to be part of the code around it
// todo so far i'm not seeing much difference trying this, but worth another look
// if (LiteralToPatch && (LiteralToPatch->Data.Literal.Value < 0x1000000ULL || LiteralToPatch->Data.Literal.Value > 0x7FFFFFFFFFFFULL)) {
// LiteralToPatch = nullptr;
// }
if (LiteralToPatch) {
bool IsMOV = (DecodeInst->OPRaw >= 0xB8 && DecodeInst->OPRaw <= 0xBF) || DecodeInst->OPRaw == 0xC7;
if (LiteralToPatch && IsMOV && LiteralToPatch->Literal() < 0x10000ULL) {
LiteralToPatch = nullptr;
}
if (LiteralToPatch && LiteralToPatch->Literal() != 0) {
Type = DataMaskType::MOV;
}
}
@@ -1478,7 +1478,7 @@ void Decoder::DetectDataMasks(uint64_t OpAddress, DecodedBlocks& Block) {
}
// jmp/call branches that use a literal rip-relative offset
// some of those may be inlined by multiblock and will be cleaned up at decode end
if (DecodeInst->TableInfo->Flags & X86Tables::InstFlags::FLAGS_SETS_RIP && DecodeInst->Src[0].IsLiteral()) {
if (DecodeInst->TableInfo->Flags & X86Tables::InstFlags::FLAGS_SETS_RIP && DecodeInst->Src[0].IsLiteral() && DecodeInst->Src[0].Literal() != 0) {
LiteralToPatch = &DecodeInst->Src[0];
Type = DataMaskType::BRANCH;
}