From 0a09e04e33776280d52e66c09d28482a055a5bc1 Mon Sep 17 00:00:00 2001 From: Tony Wasserka Date: Tue, 3 Oct 2023 11:39:46 +0200 Subject: [PATCH 1/2] Thunks: Only build guest target for libfex_thunk_test if FEXLinuxTests are enabled --- CMakeLists.txt | 2 ++ ThunkLibs/GuestLibs/CMakeLists.txt | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 58196db55..c390ddbae 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -453,6 +453,7 @@ if (BUILD_THUNKS) CMAKE_ARGS "-DBITNESS=64" "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}" + "-DBUILD_FEX_LINUX_TESTS=${BUILD_FEX_LINUX_TESTS}" "-DENABLE_CLANG_THUNKS=${ENABLE_CLANG_THUNKS}" "-DCMAKE_TOOLCHAIN_FILE:FILEPATH=${X86_64_TOOLCHAIN_FILE}" "-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}" @@ -471,6 +472,7 @@ if (BUILD_THUNKS) CMAKE_ARGS "-DBITNESS=32" "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}" + "-DBUILD_FEX_LINUX_TESTS=${BUILD_FEX_LINUX_TESTS}" "-DENABLE_CLANG_THUNKS=${ENABLE_CLANG_THUNKS}" "-DCMAKE_TOOLCHAIN_FILE:FILEPATH=${X86_32_TOOLCHAIN_FILE}" "-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}" diff --git a/ThunkLibs/GuestLibs/CMakeLists.txt b/ThunkLibs/GuestLibs/CMakeLists.txt index 69223e8a4..13cd37026 100644 --- a/ThunkLibs/GuestLibs/CMakeLists.txt +++ b/ThunkLibs/GuestLibs/CMakeLists.txt @@ -292,5 +292,7 @@ if (BITNESS EQUAL 32) target_compile_options(VDSO-guest PRIVATE "-fno-pic") endif() -generate(libfex_thunk_test ${CMAKE_CURRENT_SOURCE_DIR}/../libfex_thunk_test/libfex_thunk_test_interface.cpp) -add_guest_lib(fex_thunk_test "libfex_thunk_test.so") +if (BUILD_FEX_LINUX_TESTS) + generate(libfex_thunk_test ${CMAKE_CURRENT_SOURCE_DIR}/../libfex_thunk_test/libfex_thunk_test_interface.cpp) + add_guest_lib(fex_thunk_test "libfex_thunk_test.so") +endif() From e06d609bf009ca110edda5676b7a896f6a8cc211 Mon Sep 17 00:00:00 2001 From: Tony Wasserka Date: Tue, 3 Oct 2023 11:41:01 +0200 Subject: [PATCH 2/2] Thunks: Drop unused STRUCT_VERIFIER define from CMake --- CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c390ddbae..b20f18d85 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -457,7 +457,6 @@ if (BUILD_THUNKS) "-DENABLE_CLANG_THUNKS=${ENABLE_CLANG_THUNKS}" "-DCMAKE_TOOLCHAIN_FILE:FILEPATH=${X86_64_TOOLCHAIN_FILE}" "-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}" - "-DSTRUCT_VERIFIER=${CMAKE_SOURCE_DIR}/Scripts/StructPackVerifier.py" "-DFEX_PROJECT_SOURCE_DIR=${FEX_PROJECT_SOURCE_DIR}" "-DGENERATOR_EXE=$" INSTALL_COMMAND "" @@ -476,7 +475,6 @@ if (BUILD_THUNKS) "-DENABLE_CLANG_THUNKS=${ENABLE_CLANG_THUNKS}" "-DCMAKE_TOOLCHAIN_FILE:FILEPATH=${X86_32_TOOLCHAIN_FILE}" "-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}" - "-DSTRUCT_VERIFIER=${CMAKE_SOURCE_DIR}/Scripts/StructPackVerifier.py" "-DFEX_PROJECT_SOURCE_DIR=${FEX_PROJECT_SOURCE_DIR}" "-DGENERATOR_EXE=$" INSTALL_COMMAND ""