From 44a6bfd8740f68c93df8121e03ccbbedaab8e42a Mon Sep 17 00:00:00 2001 From: Tony Wasserka Date: Mon, 16 Feb 2026 10:26:11 +0100 Subject: [PATCH] Revert "CodeCache: Use defaulted dtor for ExecutableFileInfo" CodeCache.h has no dependency on SourcecodeResolver.h. This reverts commit f2bbc0eccda58d61bf44ee3f9a39cac61a3f75ca. --- FEXCore/Source/Interface/Core/CodeCache.cpp | 2 ++ FEXCore/include/FEXCore/Core/CodeCache.h | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/FEXCore/Source/Interface/Core/CodeCache.cpp b/FEXCore/Source/Interface/Core/CodeCache.cpp index c8954ce15..28e66be93 100644 --- a/FEXCore/Source/Interface/Core/CodeCache.cpp +++ b/FEXCore/Source/Interface/Core/CodeCache.cpp @@ -11,6 +11,7 @@ #include #include +#include #include #include @@ -29,6 +30,7 @@ ExecutableFileInfo::ExecutableFileInfo(fextl::unique_ptr Map , FileId(FileId) , Filename(Filename) {} #endif +ExecutableFileInfo::~ExecutableFileInfo() = default; fextl::string CodeMap::GetBaseFilename(const ExecutableFileInfo& MainExecutable, bool AddNombSuffix) { auto FileId = MainExecutable.FileId; diff --git a/FEXCore/include/FEXCore/Core/CodeCache.h b/FEXCore/include/FEXCore/Core/CodeCache.h index 1b9b0dd3e..5e5caa140 100644 --- a/FEXCore/include/FEXCore/Core/CodeCache.h +++ b/FEXCore/include/FEXCore/Core/CodeCache.h @@ -8,7 +8,6 @@ #include #include #include -#include #include #include @@ -32,6 +31,8 @@ enum class GuestRelocationType : uint32_t { Rel32, Rel64 }; // Generic information associated with an executable file. struct ExecutableFileInfo { + ~ExecutableFileInfo(); + #if __clang_major__ < 16 // Workaround for broken aggregate-initialization with std::piecewise_construct ExecutableFileInfo(fextl::unique_ptr, uint64_t, fextl::string);