From 9ca486883311e9a18f1d43afe056658215629351 Mon Sep 17 00:00:00 2001 From: Paulo Matos Date: Thu, 16 May 2024 10:16:01 +0200 Subject: [PATCH] Use erase-remove idiom to remove element Fixes #3631 --- FEXCore/Source/Interface/IR/Passes/RAValidation.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/FEXCore/Source/Interface/IR/Passes/RAValidation.cpp b/FEXCore/Source/Interface/IR/Passes/RAValidation.cpp index eb9f87f74..d1fe2d636 100644 --- a/FEXCore/Source/Interface/IR/Passes/RAValidation.cpp +++ b/FEXCore/Source/Interface/IR/Passes/RAValidation.cpp @@ -243,7 +243,8 @@ bool RAValidation::Run(IREmitter* IREmit) { if (IsFowardsEdge(PredecessorID) && !HaveState) { // We are probably about to visit this node anyway, remove it - std::remove(BlocksToVisit.begin(), BlocksToVisit.end(), Predecessor); + auto it = std::remove(BlocksToVisit.begin(), BlocksToVisit.end(), Predecessor); + BlocksToVisit.erase(it, BlocksToVisit.end()); // Add the missing predecessor to start of queue BlocksToVisit.push_front(Predecessor);