From 34f2bce203b3da7370b57b4fe2cfec77f2dab8f5 Mon Sep 17 00:00:00 2001 From: Ryan Houdek Date: Mon, 9 Sep 2024 17:43:35 -0700 Subject: [PATCH] FEXCore: Remove Context header include when unneeded This is one of the most expensive headers in FEX, averaging 1.2 seconds of compile time per include. We include this header 31 times around the project. Remove the five instances where it is unused to help this issue. Next step would be to make the header lighter if possible. --- FEXCore/Source/Interface/Core/Core.cpp | 1 - FEXCore/Source/Interface/Core/JIT/Arm64/ConversionOps.cpp | 1 - FEXCore/Source/Interface/Core/ObjectCache/JobHandling.cpp | 1 - .../Interface/Core/ObjectCache/NamedRegionObjectHandler.cpp | 2 -- FEXCore/Source/Interface/Core/OpcodeDispatcher/Flags.cpp | 1 - 5 files changed, 6 deletions(-) diff --git a/FEXCore/Source/Interface/Core/Core.cpp b/FEXCore/Source/Interface/Core/Core.cpp index 3ffa1753a..ed4c76d96 100644 --- a/FEXCore/Source/Interface/Core/Core.cpp +++ b/FEXCore/Source/Interface/Core/Core.cpp @@ -9,7 +9,6 @@ $end_info$ */ #include -#include "Interface/Context/Context.h" #include "Interface/Core/ArchHelpers//Arm64Emitter.h" #include "Interface/Core/LookupCache.h" #include "Interface/Core/CPUBackend.h" diff --git a/FEXCore/Source/Interface/Core/JIT/Arm64/ConversionOps.cpp b/FEXCore/Source/Interface/Core/JIT/Arm64/ConversionOps.cpp index f062cc6dc..01d9724d6 100644 --- a/FEXCore/Source/Interface/Core/JIT/Arm64/ConversionOps.cpp +++ b/FEXCore/Source/Interface/Core/JIT/Arm64/ConversionOps.cpp @@ -5,7 +5,6 @@ tags: backend|arm64 $end_info$ */ -#include "Interface/Context/Context.h" #include "Interface/Core/JIT/Arm64/JITClass.h" namespace FEXCore::CPU { diff --git a/FEXCore/Source/Interface/Core/ObjectCache/JobHandling.cpp b/FEXCore/Source/Interface/Core/ObjectCache/JobHandling.cpp index 7b81cc144..5c707eb87 100644 --- a/FEXCore/Source/Interface/Core/ObjectCache/JobHandling.cpp +++ b/FEXCore/Source/Interface/Core/ObjectCache/JobHandling.cpp @@ -1,5 +1,4 @@ // SPDX-License-Identifier: MIT -#include "Interface/Context/Context.h" #include "Interface/Core/ObjectCache/ObjectCacheService.h" #include diff --git a/FEXCore/Source/Interface/Core/ObjectCache/NamedRegionObjectHandler.cpp b/FEXCore/Source/Interface/Core/ObjectCache/NamedRegionObjectHandler.cpp index f2beb7d59..2bfc378b4 100644 --- a/FEXCore/Source/Interface/Core/ObjectCache/NamedRegionObjectHandler.cpp +++ b/FEXCore/Source/Interface/Core/ObjectCache/NamedRegionObjectHandler.cpp @@ -1,8 +1,6 @@ // SPDX-License-Identifier: MIT -#include "Interface/Context/Context.h" #include "Interface/Core/ObjectCache/ObjectCacheService.h" - #include #include diff --git a/FEXCore/Source/Interface/Core/OpcodeDispatcher/Flags.cpp b/FEXCore/Source/Interface/Core/OpcodeDispatcher/Flags.cpp index 3d7992385..4ae055ee4 100644 --- a/FEXCore/Source/Interface/Core/OpcodeDispatcher/Flags.cpp +++ b/FEXCore/Source/Interface/Core/OpcodeDispatcher/Flags.cpp @@ -6,7 +6,6 @@ desc: Handles x86/64 flag generation $end_info$ */ -#include "Interface/Context/Context.h" #include "Interface/Core/OpcodeDispatcher.h" #include "Interface/Core/X86Tables/X86Tables.h"