From 23d07d7d0cd84734dc72eeaa5ffe40504e16ece6 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Sat, 10 Aug 2024 17:04:17 -0400 Subject: [PATCH] OpcodeDispatcher: fix folding negative offsets for 32-bit I don't know what I was thinking when I wrote that code. Drop the silly logic and let ConstProp inline the immediates. This fixes a lot of silly code generated for 32-bit. Signed-off-by: Alyssa Rosenzweig --- FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp b/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp index 35094893d..0fea6b93e 100644 --- a/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp +++ b/FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp @@ -4311,7 +4311,7 @@ AddressMode OpDispatchBuilder::SelectAddressMode(AddressMode A, bool AtomicTSO, return { .Base = A.Base, .Index = _Constant(A.Offset), - .IndexType = (Const_16K && A.Offset < 0) ? MEM_OFFSET_SXTW : MEM_OFFSET_SXTX, + .IndexType = MEM_OFFSET_SXTX, .IndexScale = 1, }; }