From 1e829a47fabb3f71b0cfe555381840c5563e67b6 Mon Sep 17 00:00:00 2001 From: Ryan Houdek Date: Wed, 19 Jul 2023 15:23:07 -0700 Subject: [PATCH] ThunksDB: Adds X11 dependency to XCB I was hitting an issue where thunking in Wine+Vulkan applications was breaking unless both OpenGL and Vulkan was enabled. Turns out this was because Vulkan enabled only XCB, which didn't enable X11. So when XCB is thunked but X11 isn't, this causes weird issues where X11 calls in to XCB functions and gets in desync'ed state. Causing hangs to appear in xcb_take_socket. Now we can enabled just `Vulkan` as a thunk and it'll work fine. ``` (gdb) bt from target:/usr/lib/fex-emu/HostThunks//libvulkan-host.so ``` --- Data/ThunksDB.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Data/ThunksDB.json b/Data/ThunksDB.json index 00a307af9..e53dbee8d 100644 --- a/Data/ThunksDB.json +++ b/Data/ThunksDB.json @@ -46,6 +46,9 @@ ] }, "xcb": { + "Depends": [ + "X11" + ], "Library": "libxcb-guest.so", "Overlay": [ "@PREFIX_LIB@/libxcb.so",